Bug 135146 - [ftlopt] Get rid of structure checks as a way of checking if a function is in fact a function
Summary: [ftlopt] Get rid of structure checks as a way of checking if a function is in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 135145
  Show dependency tree / graph
 
Reported: 2014-07-21 20:21 PDT by Filip Pizlo
Modified: 2014-07-22 21:16 PDT (History)
8 users (show)

See Also:

Attachments
work in progress (30.80 KB, patch)
2014-07-21 22:42 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (33.95 KB, patch)
2014-07-22 19:14 PDT, Filip Pizlo 		oliver: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-07-21 20:21:36 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2014-07-21 22:42:30 PDT 
Created attachment 235268 [details]
work in progress

I accidentally wrote this against trunk.  It passes tests but I haven't checked performance.  I'll rebase it onto the branch and do performance testing there.
Comment 2 Filip Pizlo 2014-07-22 19:14:13 PDT 
Created attachment 235338 [details]
the patch
Comment 3 Oliver Hunt 2014-07-22 20:49:57 PDT 
Comment on attachment 235338 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235338&action=review

> Source/JavaScriptCore/dfg/DFGUseKind.cpp:42
> -        break;
> +        return;

i kind of wish the s/break/return/ change was separate but not enough to r- or anything :)
Comment 4 Filip Pizlo 2014-07-22 21:16:30 PDT 
Landed in http://trac.webkit.org/changeset/171389