Bug 135131

Summary:

WebVideoFullscreenInterfaceAVKit leaks AVPlayerViewController

Product:

WebKit

Reporter:

Jeremy Jones <jeremyj-wk>

Component:

Media

Assignee:

Jeremy Jones <jeremyj-wk>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, eric.carlson, glenn, jer.noble, jonlee, philipj, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

iPhone / iPad

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Description Jeremy Jones 2014-07-21 14:21:59 PDT

WebVideoFullscreenInterfaceAVKit leaks AVPlayerViewController

Comment 1 Jeremy Jones 2014-07-21 14:25:40 PDT

Created attachment 235246 [details]
Patch

Comment 2 Eric Carlson 2014-07-21 17:40:51 PDT

Comment on attachment 235246 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235246&action=review

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:865
>      [m_window setRootViewController:nil];
>      [m_playerViewController setDelegate:nil];
>      [m_playerViewController setPlayerController:nil];
> +    [[m_playerViewController view] removeFromSuperview];
> +    [m_playerViewController removeFromParentViewController];
>      m_playerViewController = nil;
>      m_viewController = nil;
>      m_window = nil;
>      [m_videoLayer removeFromSuperlayer];
>      m_videoLayer = nil;
>      [m_videoLayerContainer removeFromSuperlayer];
> +    [m_videoLayerContainer setPlayerViewController:nil];
>      m_videoLayerContainer = nil;

Please file a bug to consolidate the duplicate code in invalidate and cleanupFullscreen.

Comment 3 Jon Lee 2014-07-24 21:44:09 PDT

<rdar://problem/17751079>