Summary: | DatabaseProcess doesn't relaunch after crashing | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
Component: | WebKit2 | Assignee: | Brady Eidson <beidson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | Keywords: | InRadar | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Brady Eidson
2014-07-21 09:40:06 PDT
Created attachment 235222 [details]
Patch v1
Comment on attachment 235222 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=235222&action=review > Source/WebKit2/UIProcess/WebContext.cpp:499 > + WebContextSupplementMap::const_iterator it = m_supplements.begin(); > + WebContextSupplementMap::const_iterator end = m_supplements.end(); > + for (; it != end; ++it) We can't have a C++11 loop here, can we? (In reply to comment #2) > (From update of attachment 235222 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=235222&action=review > > > Source/WebKit2/UIProcess/WebContext.cpp:499 > > + WebContextSupplementMap::const_iterator it = m_supplements.begin(); > > + WebContextSupplementMap::const_iterator end = m_supplements.end(); > > + for (; it != end; ++it) > > We can't have a C++11 loop here, can we? Considered it, decided on replicating the pattern used twice before. Now you've made me go back the other way. Will change. Comment on attachment 235222 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=235222&action=review >>> Source/WebKit2/UIProcess/WebContext.cpp:499 >>> + for (; it != end; ++it) >> >> We can't have a C++11 loop here, can we? > > Considered it, decided on replicating the pattern used twice before. Now you've made me go back the other way. Will change. It’s especially good if you use values(). (In reply to comment #5) > (From update of attachment 235222 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=235222&action=review > > >>> Source/WebKit2/UIProcess/WebContext.cpp:499 > >>> + for (; it != end; ++it) > >> > >> We can't have a C++11 loop here, can we? > > > > Considered it, decided on replicating the pattern used twice before. Now you've made me go back the other way. Will change. > > It’s especially good if you use values(). That definitely would've been even better than what I landed. |