Summary: | [iOS] a Paused media session is not active | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||
Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, darin, glenn, jeremyj-wk, jer.noble, philipj, sergio | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Eric Carlson
2014-07-20 19:43:14 PDT
Created attachment 235200 [details]
Proposed patch
With no regression test, we’re a little vulnerable here. Might be nice to have a brief comment explaining why this function does exactly what it does. (In reply to comment #3) > With no regression test, we’re a little vulnerable here. Might be nice to have a brief comment explaining why this function does exactly what it does. Good point. I renamed MediaSessionManager::hasActive to "activeAudioSessionRequired" to make obvious what the method does. Committed r171299 - https://trac.webkit.org/r171299 |