Bug 135101 – Add helper functions to dump the scrolling state tree from the debugger

• Component: New Bugs
• Status: RESOLVED FIXED

[Simon Fraser (smfr)]

Add helper functions to dump the scrolling state tree from the debugger

[Simon Fraser (smfr)]

Created attachment 235185 [details]
Patch

[Darin Adler]

Comment on attachment 235185 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235185&action=review

> Source/WebCore/page/scrolling/ScrollingStateTree.cpp:39
> +#ifndef NDEBUG
> +#include <wtf/Text/CString.h>
> +#endif

I think we should just include this unconditionally.

> Source/WebCore/page/scrolling/ScrollingStateTree.cpp:254
> +#ifndef NDEBUG
> +void showScrollingStateTree(const WebCore::ScrollingStateTree* tree)

Please add a blank line here.

> Source/WebCore/page/scrolling/ScrollingStateTree.cpp:257
> +    if (!tree)
> +        return;

Silent? Maybe print something for clarity?

> Source/WebCore/page/scrolling/ScrollingStateTree.cpp:259
> +    const WebCore::ScrollingStateNode* rootNode = tree->rootStateNode();

I would just do auto* here; the complete typename and const is utterly uninteresting.

> Source/WebCore/page/scrolling/ScrollingStateTree.cpp:272
> +    if (!node)
> +        return;

Silent? Maybe print something for clarity?

> Source/WebCore/page/scrolling/ScrollingStateTree.h:111
> +#ifndef NDEBUG
> +void showScrollingStateTree(const WebCore::ScrollingStateTree*);
> +void showScrollingStateTree(const WebCore::ScrollingStateNode*);
> +#endif

Does it really need to be in the header? Can’t we just put this at the top of the .cpp file?

[Build Bot]

Comment on attachment 235185 [details]
Patch

Attachment 235185 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5735317537554432

New failing tests:
media/W3C/audio/networkState/networkState_initial.html
media/track/track-long-word-container-sizing.html

[Build Bot]

Created attachment 235189 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Simon Fraser (smfr)]

https://trac.webkit.org/r171307