Bug 135081

Summary: [iOS] ignore requests to set volume
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, glenn, jer.noble, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch none

Eric Carlson
Reported 2014-07-18 19:03:47 PDT
The iOS media player should ignore requests to change volume.
Attachments
Proposed patch (1.29 KB, patch)
2014-07-18 19:09 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2014-07-18 19:09:52 PDT
Created attachment 235164 [details] Proposed patch
WebKit Commit Bot
Comment 2 2014-07-18 22:26:08 PDT
Comment on attachment 235164 [details] Proposed patch Clearing flags on attachment: 235164 Committed r171259: <http://trac.webkit.org/changeset/171259>
WebKit Commit Bot
Comment 3 2014-07-18 22:26:11 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 4 2014-07-19 22:38:21 PDT
Comment on attachment 235164 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=235164&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1113 > +#if PLATFORM(IOS) > + return; > +#endif This is a peculiar way to do it. In the many cases like this one we compile out the code rather than adding a return and leaving unreachable code after the return like this.
Eric Carlson
Comment 5 2014-07-20 09:46:51 PDT
(In reply to comment #4) > (From update of attachment 235164 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=235164&action=review > > > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1113 > > +#if PLATFORM(IOS) > > + return; > > +#endif > > This is a peculiar way to do it. In the many cases like this one we compile out the code rather than adding a return and leaving unreachable code after the return like this. Good point. Fixed in r171279: http://trac.webkit.org/changeset/171279
Note You need to log in before you can comment on or make changes to this bug.