Bug 135059

Summary:

Refactor run-jsc-stress-tests VM copying code to remove some abstractions

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

Tools / Tests

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, clopez, ggaren, mark.lam, mhahnenberg, mmirman, msaboff, oliver, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	mark.lam: review+

Description Filip Pizlo 2014-07-18 12:05:56 PDT

Patch forthcoming.

Comment 1 Filip Pizlo 2014-07-18 12:08:44 PDT

Created attachment 235135 [details]
the patch

Comment 2 Mark Lam 2014-07-18 12:10:55 PDT

Comment on attachment 235135 [details]
the patch

r=me

Comment 3 Filip Pizlo 2014-07-18 12:14:13 PDT

Landed in http://trac.webkit.org/changeset/171233

Comment 4 Carlos Alberto Lopez Perez 2014-07-18 14:37:21 PDT

This broke run-jsc-stress-tests on both EFL and GTK:

Tools/Scripts/run-jsc-stress-tests:1058:in `prepareBundle': undefined local variable or method `jscPath' for main:Object (NameError)
	from Tools/Scripts/run-jsc-stress-tests:1420:in `runNormal'
	from Tools/Scripts/run-jsc-stress-tests:1452:in `<main>'

Comment 5 Filip Pizlo 2014-07-18 14:47:04 PDT

(In reply to comment #4)
> This broke run-jsc-stress-tests on both EFL and GTK:
> 
> Tools/Scripts/run-jsc-stress-tests:1058:in `prepareBundle': undefined local variable or method `jscPath' for main:Object (NameError)
>     from Tools/Scripts/run-jsc-stress-tests:1420:in `runNormal'
>     from Tools/Scripts/run-jsc-stress-tests:1452:in `<main>'

I see it, fix on the way.

Comment 6 Filip Pizlo 2014-07-18 15:09:02 PDT

(In reply to comment #5)
> (In reply to comment #4)
> > This broke run-jsc-stress-tests on both EFL and GTK:
> > 
> > Tools/Scripts/run-jsc-stress-tests:1058:in `prepareBundle': undefined local variable or method `jscPath' for main:Object (NameError)
> >     from Tools/Scripts/run-jsc-stress-tests:1420:in `runNormal'
> >     from Tools/Scripts/run-jsc-stress-tests:1452:in `<main>'
> 
> I see it, fix on the way.

Fixed in http://trac.webkit.org/changeset/171245