Bug 135057 – Add 'analyze' target to the Makefiles

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Dana Burkart]

I would like to run the clang static analyzer from the command line, and have a per-project breakdown of the results. In order to do that, each xcodebuild invocation needs to be wrapped in a call to scan-build (http://clang-analyzer.llvm.org/scan-build.html). I have a patch which adds a new 'analyze' target to allow for this.

[Dana Burkart]

Created attachment 235132 [details]
Proposed patch.

I've attached a patch to accomplish this.

[Build Bot]

Comment on attachment 235132 [details]
Proposed patch.

Attachment 235132 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5848274372132864

New failing tests:
media/W3C/video/src/src_reflects_attribute_not_source_elements.html

[Build Bot]

Created attachment 235141 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Dana Burkart]

Created attachment 235150 [details]
Updated patch

Updated patch to output static analysis to the command line if PATH_TO_SCAN_BUILD is not set.

[David Kilzer (:ddkilzer)]

Comment on attachment 235150 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235150&action=review

r=me

> Makefile.shared:28
>  
> +

Unintentional blank lined added?

> Makefile.shared:41
> +analyze:
> +	$(SCRIPTS_PATH)/set-webkit-configuration --release

It would be nice if we could support analyze with --debug builds as well. Maybe add a STYLE=debug argument to the make command such that unset STYLE defaults to 'release', but lets you override to 'debug'.

This can be added later, though.

[Mark Rowe (bdash)]

Was this landed?

[Dana Burkart]

Yes, this was landed.