Bug 135013

Summary: [CSS Grid Layout] Rename gridAutoFlow[Row|Column] to gridAutoFlow[Row|Column]Sparse
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: Tools / TestsAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jfernandez, svillar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 103316    
Attachments:
Description Flags
Patch none

Manuel Rego Casasnovas
Reported 2014-07-17 09:18:14 PDT
In the layout tests we're using gridAutoFlowRow and gridAutoFlowColumn, which implies that the auto-placement algorithm is using "sparse" mode (as this is the default mode). Changing it to gridAutoFlowRowSparse and gridAutoFlowColumnSparse to make it more explicit. This is being managed in https://codereview.chromium.org/401473003/
Attachments
Patch (40.89 KB, patch)
2014-07-17 09:39 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2014-07-17 09:39:56 PDT
Created attachment 235069 [details] Patch
WebKit Commit Bot
Comment 2 2014-07-21 00:46:57 PDT
Comment on attachment 235069 [details] Patch Clearing flags on attachment: 235069 Committed r171293: <http://trac.webkit.org/changeset/171293>
WebKit Commit Bot
Comment 3 2014-07-21 00:46:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.