Bug 135012

Summary: Remove the unused variable in SubresourceLoader::willSendRequest()
Product: WebKit Reporter: Keonil Jeong <keonil.jeong>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: ahmad.saleem792, ap, commit-queue, japhet, koivisto, mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch mitz: review+

Description Keonil Jeong 2014-07-17 01:00:41 PDT 
In SubresourceLoader::willSendRequest(), the previousURL variable is no more necessary.
Comment 1 Keonil Jeong 2014-07-17 01:30:04 PDT 
Created attachment 235057 [details]
Patch
Comment 2 WebKit Commit Bot 2014-07-17 01:31:59 PDT 
Attachment 235057 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Keonil Jeong 2014-07-17 01:39:59 PDT 
Created attachment 235058 [details]
Patch
Comment 4 Keonil Jeong 2014-07-18 01:25:33 PDT 
the fail of window build is not related to this patch.
Comment 5 Keonil Jeong 2014-07-30 17:09:04 PDT 
Created attachment 235781 [details]
Patch
Comment 6 mitz 2014-08-01 21:22:10 PDT 
Comment on attachment 235781 [details]
Patch

I found that the last use of this variable was removed in <http://trac.webkit.org/r145735>.
Comment 7 Ahmad Saleem 2024-02-24 15:29:00 PST 
This didn't landed but I couldn't find the variable as well:

(SubresourceLoader::willSendRequestInternal)

https://searchfox.org/wubkat/rev/dc6a01c9fd207e1b1394a1cb8261b410a1909cf6/Source/WebCore/loader/SubresourceLoader.cpp#207