Bug 135012

Summary: Remove the unused variable in SubresourceLoader::willSendRequest()
Product: WebKit Reporter: Keonil Jeong <keonil.jeong>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: ahmad.saleem792, ap, commit-queue, japhet, koivisto, mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch mitz: review+

Keonil Jeong
Reported 2014-07-17 01:00:41 PDT
In SubresourceLoader::willSendRequest(), the previousURL variable is no more necessary.
Attachments
Patch (1.38 KB, patch)
2014-07-17 01:30 PDT, Keonil Jeong 		no flags
DetailsFormatted DiffDiff
Patch (1.44 KB, patch)
2014-07-17 01:39 PDT, Keonil Jeong 		no flags
DetailsFormatted DiffDiff
Patch (1.65 KB, patch)
2014-07-30 17:09 PDT, Keonil Jeong 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Keonil Jeong
Comment 1 2014-07-17 01:30:04 PDT
Created attachment 235057 [details] Patch
WebKit Commit Bot
Comment 2 2014-07-17 01:31:59 PDT
Attachment 235057 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style.
Keonil Jeong
Comment 3 2014-07-17 01:39:59 PDT
Created attachment 235058 [details] Patch
Keonil Jeong
Comment 4 2014-07-18 01:25:33 PDT
the fail of window build is not related to this patch.
Keonil Jeong
Comment 5 2014-07-30 17:09:04 PDT
Created attachment 235781 [details] Patch
mitz
Comment 6 2014-08-01 21:22:10 PDT
Comment on attachment 235781 [details] Patch I found that the last use of this variable was removed in <http://trac.webkit.org/r145735>.
Ahmad Saleem
Comment 7 2024-02-24 15:29:00 PST
This didn't landed but I couldn't find the variable as well: (SubresourceLoader::willSendRequestInternal) https://searchfox.org/wubkat/rev/dc6a01c9fd207e1b1394a1cb8261b410a1909cf6/Source/WebCore/loader/SubresourceLoader.cpp#207
Note You need to log in before you can comment on or make changes to this bug.