Bug 135007

Summary: sputnik/Implementation_Diagnostics/S12.6.4_D1.html depends on undefined behavior
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Mark Hahnenberg 2014-07-16 20:43:04 PDT 
EcmaScript 5.1 specifies that during for-in enumeration newly added properties may or may not be visited during the current enumeration. Specifically, in section 12.6.4 the spec states:

"If new properties are added to the object being enumerated during enumeration, the newly added properties are not guaranteed to be visited in the active enumeration."

The sputnik/Implementation_Diagnostics/S12.6.4_D1.html layout test is from before sputnik was added to the test262 suite. I believe it has since been removed, so it would probably be okay to remove it from our layout test suite.
Comment 1 Mark Hahnenberg 2014-07-16 20:48:42 PDT 
Created attachment 235049 [details]
Patch
Comment 2 Filip Pizlo 2014-07-16 20:56:17 PDT 
Comment on attachment 235049 [details]
Patch

Is it part of test262?
Comment 3 Mark Hahnenberg 2014-07-16 21:14:18 PDT 
(In reply to comment #2)
> (From update of attachment 235049 [details])
> Is it part of test262?

I don't think it is any more. I have a patch that breaks this test but the section 12 test262 tests pass.
Comment 4 Mark Hahnenberg 2014-07-16 21:14:54 PDT 
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 235049 [details] [details])
> > Is it part of test262?
> 
> I don't think it is any more. I have a patch that breaks this test but the section 12 test262 tests pass.

I guess it might never have been added to test262 though...
Comment 5 Mark Hahnenberg 2014-07-18 13:27:10 PDT 
Fix landed in http://trac.webkit.org/changeset/171189.
Comment 6 Mark Hahnenberg 2014-07-18 13:27:30 PDT 
Comment on attachment 235049 [details]
Patch

Clearing review flag.