Summary: | [CSS Grid Layout] Add element.style coverage for grid-auto-flow | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Manuel Rego Casasnovas <rego> | ||||||||
Component: | Tools / Tests | Assignee: | Manuel Rego Casasnovas <rego> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, jfernandez, svillar | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 103316 | ||||||||||
Attachments: |
|
Description
Manuel Rego Casasnovas
2014-07-16 02:16:22 PDT
Created attachment 234983 [details]
Patch
JFTR, this has been already landed on Blink: https://codereview.chromium.org/360233002/ Comment on attachment 234983 [details]
Patch
I agree with the patch but now that I see the test I think it's time to creating something like testGridDefinitionsSetJSValues() but for grid auto flow. It'd be something like checkGridDefinitionsSetJSValues() but very simplified:
{
create node
set style
match result with expected result passed as argument
remove node
}
Created attachment 235060 [details]
Patch
Apply suggested changes.
Created attachment 235067 [details]
Patch
Replace checkGridAutoFlowCSSSetCSSValue by checkGridAutoFlowSetCSSValue.
Comment on attachment 235067 [details]
Patch
Go go go!
Comment on attachment 235067 [details] Patch Clearing flags on attachment: 235067 Committed r171183: <http://trac.webkit.org/changeset/171183> All reviewed patches have been landed. Closing bug. |