Bug 134966

Summary: [CSS Grid Layout] Add element.style coverage for grid-auto-flow
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: Tools / TestsAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jfernandez, svillar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 103316    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Manuel Rego Casasnovas
Reported 2014-07-16 02:16:22 PDT
We should check element.style for grid-auto-flow property in fast/css-grid-layout/grid-auto-flow-get-set.html test. The test was modified in bug #134057 but element.style was not checked there.
Attachments
Patch (9.54 KB, patch)
2014-07-16 02:18 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch (19.52 KB, patch)
2014-07-17 02:41 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch (19.45 KB, patch)
2014-07-17 07:32 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2014-07-16 02:18:16 PDT
Created attachment 234983 [details] Patch
Manuel Rego Casasnovas
Comment 2 2014-07-16 02:19:31 PDT
JFTR, this has been already landed on Blink: https://codereview.chromium.org/360233002/
Sergio Villar Senin
Comment 3 2014-07-16 02:25:46 PDT
Comment on attachment 234983 [details] Patch I agree with the patch but now that I see the test I think it's time to creating something like testGridDefinitionsSetJSValues() but for grid auto flow. It'd be something like checkGridDefinitionsSetJSValues() but very simplified: { create node set style match result with expected result passed as argument remove node }
Manuel Rego Casasnovas
Comment 4 2014-07-17 02:41:05 PDT
Created attachment 235060 [details] Patch Apply suggested changes.
Manuel Rego Casasnovas
Comment 5 2014-07-17 07:32:01 PDT
Created attachment 235067 [details] Patch Replace checkGridAutoFlowCSSSetCSSValue by checkGridAutoFlowSetCSSValue.
Sergio Villar Senin
Comment 6 2014-07-17 08:10:58 PDT
Comment on attachment 235067 [details] Patch Go go go!
WebKit Commit Bot
Comment 7 2014-07-17 08:58:33 PDT
Comment on attachment 235067 [details] Patch Clearing flags on attachment: 235067 Committed r171183: <http://trac.webkit.org/changeset/171183>
WebKit Commit Bot
Comment 8 2014-07-17 08:58:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.