Bug 134865

Summary: [Cocoa] Notify the client when a navigation snapshot is taken
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, jfernandez, sam, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Add -_webView:willSnapshotBackForwardListItem: sam: review+

mitz
Reported 2014-07-12 19:58:11 PDT
[Cocoa] Notify the client when a navigation snapshot is taken
Attachments
Add -_webView:willSnapshotBackForwardListItem: (10.91 KB, patch)
2014-07-12 20:12 PDT, mitz 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2014-07-12 20:12:54 PDT
Created attachment 234821 [details] Add -_webView:willSnapshotBackForwardListItem:
WebKit Commit Bot
Comment 2 2014-07-12 20:15:07 PDT
Attachment 234821 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.h:170: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 3 2014-07-12 22:52:01 PDT
Committed <http://trac.webkit.org/r171045>.
Javier Fernandez
Comment 4 2014-07-14 02:39:41 PDT
This broke gtk+ build, but it has been fixed in bug #134867
Note You need to log in before you can comment on or make changes to this bug.