Bug 134861

Summary: REGRESSION(r171034) [GTK] Build broken.
Product: WebKit Reporter: Javier Fernandez <jfernandez>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cgarcia, commit-queue, gustavo, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Javier Fernandez 2014-07-12 17:16:03 PDT 
GTK Build was broken due to r171034 <http://trac.webkit.org/r171034>
Comment 1 Javier Fernandez 2014-07-12 17:18:35 PDT 
Created attachment 234814 [details]
Patch
Comment 2 WebKit Commit Bot 2014-07-12 17:21:23 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Javier Fernandez 2014-07-12 17:26:48 PDT 
Created attachment 234815 [details]
Patch
Comment 4 Darin Adler 2014-07-12 17:38:19 PDT 
Comment on attachment 234815 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234815&action=review

> Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:395
> +void PageClientImpl::navigationGestureWillEnd(bool willNavigate, WebBackForwardListItem&)
> +{
> +}
> +
> +void PageClientImpl::navigationGestureDidEnd(bool willNavigate, WebBackForwardListItem&)
> +{
> +}

Should omit argument names here to avoid unused argument warnings.
Comment 5 Javier Fernandez 2014-07-12 17:43:12 PDT 
Created attachment 234816 [details]
Patch
Comment 6 Javier Fernandez 2014-07-12 17:54:07 PDT 
Created attachment 234818 [details]
Patch
Comment 7 WebKit Commit Bot 2014-07-12 18:10:17 PDT 
Comment on attachment 234818 [details]
Patch

Clearing flags on attachment: 234818

Committed r171040: <http://trac.webkit.org/changeset/171040>
Comment 8 WebKit Commit Bot 2014-07-12 18:10:21 PDT 
All reviewed patches have been landed.  Closing bug.