Summary: | Provide some large JPEG images with EXIF orientation for subsampling tests | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
Component: | New Bugs | Assignee: | Dean Jackson <dino> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, simon.fraser, thorton | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Dean Jackson
2014-07-11 16:06:55 PDT
Created attachment 234789 [details]
Patch
Comment on attachment 234789 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234789&action=review > LayoutTests/ChangeLog:12 > + Four images (either 3000x2000 or 2000x3000) that each have EXIF rotation > + attributes that should render with an arrow pointing UP. The > + orientation-rotate-0.jpg should always render correctly, even if EXIF > + rotation is ignored. The others are variations on that image that were > + saved in rotated form, then reverted to the correct orientation via EXIF. Hmmm... I don't understand why the patch tool is showing them in their source orientation and ignoring the EXIF. If you open them in an image document, the orientation is correct. I don't know if this is a bug. (In reply to comment #2) > (From update of attachment 234789 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=234789&action=review > > > LayoutTests/ChangeLog:12 > > + Four images (either 3000x2000 or 2000x3000) that each have EXIF rotation > > + attributes that should render with an arrow pointing UP. The > > + orientation-rotate-0.jpg should always render correctly, even if EXIF > > + rotation is ignored. The others are variations on that image that were > > + saved in rotated form, then reverted to the correct orientation via EXIF. > > Hmmm... I don't understand why the patch tool is showing them in their source orientation and ignoring the EXIF. If you open them in an image document, the orientation is correct. I don't know if this is a bug. That's what happens on Mac Safari at the moment. Comment on attachment 234789 [details] Patch Clearing flags on attachment: 234789 Committed r171097: <http://trac.webkit.org/changeset/171097> All reviewed patches have been landed. Closing bug. Two things :) 1. the images should be in fast/images/resources 2. these are progressive JPEGs, which we don't try to subsample |