Summary: | Captions container should never clip content | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Roger Fong <roger_fong> | ||||||||
Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bfulgham, buildbot, calvaris, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, jonlee, philipj, rniwa, roger_fong, sergio, simon.fraser, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Roger Fong
2014-07-11 13:28:13 PDT
Created attachment 234897 [details]
patch
Comment on attachment 234897 [details] patch Attachment 234897 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4791453913972736 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html media/track/track-in-band-subtitles-too-large.html Created attachment 234901 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 235016 [details]
patch
Comment on attachment 235016 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=235016&action=review > Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:712 > + word-break: normal; This is the default value; do you need to specify it at all? (In reply to comment #7) > (From update of attachment 235016 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=235016&action=review > > > Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:712 > > + word-break: normal; > > This is the default value; do you need to specify it at all? Hmm I suppose not. I'll get rid of it and double check to make sure that there's no other style that it falls back to. This broke two tests: <http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK1%20(Tests)/r171166%20(7405)/results.html>. Roger, are you available to land a fix ASAP? Tests added in this patch still fail - Roger marked them as failing on some bots, but they actually fail pretty much everywhere. Filed bug 135160. |