Bug 134817

Summary: [EFL] Build fix after r170970 and r170974
Product: WebKit Reporter: Jinwoo Song <jinwoo7.song>
Component: WebKit Misc.Assignee: Jinwoo Song <jinwoo7.song>
Status: RESOLVED INVALID    
Severity: Normal CC: oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jinwoo Song
Reported 2014-07-10 16:37:43 PDT
Guard the Mac specific code with macro.
Attachments
Patch (4.23 KB, patch)
2014-07-10 16:45 PDT, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Patch (4.41 KB, patch)
2014-07-10 17:49 PDT, Jinwoo Song 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jinwoo Song
Comment 1 2014-07-10 16:45:25 PDT
Created attachment 234732 [details] Patch
Tim Horton
Comment 2 2014-07-10 17:39:03 PDT
Comment on attachment 234732 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234732&action=review r+ from me for the view snapshot part, but the OpenGL part seems sufficiently platform agnostic, I'm not sure why this is needed > Source/WebKit2/Shared/SessionState.h:31 > +#if PLATFORM(COCOA) > #include "ViewSnapshotStore.h" > +#endif This needs to go in its own block, below the rest of the includes, with a empty line separating it from the others.
Jinwoo Song
Comment 3 2014-07-10 17:49:30 PDT
Created attachment 234734 [details] Patch Applied Tim's comment but waiting review for OpenGL part.
Jinwoo Song
Comment 4 2014-07-10 21:32:43 PDT
view snapshot part is fixed by r170989 by Carlos. So I fixed OpenGL part by implementing dummy method in EFL port. (r170990)
Note You need to log in before you can comment on or make changes to this bug.