Bug 134809

Summary: [MSE] Separate MediaSource logging into its own log channel
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, eric.carlson, glenn, ltilve, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch eric.carlson: review+

Jer Noble
Reported 2014-07-10 12:13:37 PDT
[MSE] Separate MediaSource logging into its own log channel
Attachments
Patch (16.33 KB, patch)
2014-07-10 12:23 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (16.33 KB, patch)
2014-07-11 08:53 PDT, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2014-07-10 12:23:18 PDT
Created attachment 234717 [details] Patch
Jer Noble
Comment 2 2014-07-11 08:53:03 PDT
Created attachment 234765 [details] Patch
Eric Carlson
Comment 3 2014-07-11 09:09:46 PDT
Comment on attachment 234765 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234765&action=review Nice change. Extra points for using "sequester" in the ChangeLog! > Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:645 > + m_client->sourceBufferPrivateDidReceiveSample(this, mediaSample); Should be mediaSample.release().
Jer Noble
Comment 4 2014-07-11 17:54:56 PDT
Committed r171017: <http://trac.webkit.org/changeset/171017>
Note You need to log in before you can comment on or make changes to this bug.