Bug 134809

Summary:

[MSE] Separate MediaSource logging into its own log channel

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

calvaris, commit-queue, eric.carlson, glenn, ltilve, philipj, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	eric.carlson: review+

Description Jer Noble 2014-07-10 12:13:37 PDT

[MSE] Separate MediaSource logging into its own log channel

Comment 1 Jer Noble 2014-07-10 12:23:18 PDT

Created attachment 234717 [details]
Patch

Comment 2 Jer Noble 2014-07-11 08:53:03 PDT

Created attachment 234765 [details]
Patch

Comment 3 Eric Carlson 2014-07-11 09:09:46 PDT

Comment on attachment 234765 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234765&action=review

Nice change. Extra points for using "sequester" in the ChangeLog!

> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:645
> +        m_client->sourceBufferPrivateDidReceiveSample(this, mediaSample);

Should be mediaSample.release().

Comment 4 Jer Noble 2014-07-11 17:54:56 PDT

Committed r171017: <http://trac.webkit.org/changeset/171017>