Bug 134809 - [MSE] Separate MediaSource logging into its own log channel
Summary: [MSE] Separate MediaSource logging into its own log channel
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-10 12:13 PDT by Jer Noble
Modified: 2014-07-11 17:54 PDT (History)
7 users (show)

See Also:


Attachments
Patch (16.33 KB, patch)
2014-07-10 12:23 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (16.33 KB, patch)
2014-07-11 08:53 PDT, Jer Noble
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2014-07-10 12:13:37 PDT
[MSE] Separate MediaSource logging into its own log channel
Comment 1 Jer Noble 2014-07-10 12:23:18 PDT
Created attachment 234717 [details]
Patch
Comment 2 Jer Noble 2014-07-11 08:53:03 PDT
Created attachment 234765 [details]
Patch
Comment 3 Eric Carlson 2014-07-11 09:09:46 PDT
Comment on attachment 234765 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234765&action=review

Nice change. Extra points for using "sequester" in the ChangeLog!

> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:645
> +        m_client->sourceBufferPrivateDidReceiveSample(this, mediaSample);

Should be mediaSample.release().
Comment 4 Jer Noble 2014-07-11 17:54:56 PDT
Committed r171017: <http://trac.webkit.org/changeset/171017>