Bug 134802 – [GTK] Reduce the size of the tarball generated by distcheck

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

We are still including a lot of files we don't really need.

[Carlos Garcia Campos]

Created attachment 234707 [details]
Patch

Before:
webkitgtk-2.5.1.tar.xz 13MB 15285 files

After:
webkitgtk-2.5.1.tar.xz 11MB 12829 files

Still bigger than stable:
webkitgtk-2.4.4.tar.xz 9,4MB 9994 files

[Martin Robinson]

Comment on attachment 234707 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234707&action=review

> Tools/gtk/manifest.txt:51
> +exclude Source/autotools

This is unnecessary now, right?

> Tools/gtk/manifest.txt:73
> +# Inlcude only the resources we actually build

Inlcude -> Include

[Martin Robinson]

(In reply to comment #1)
> Created an attachment (id=234707) [details]
> Patch
> 
> Before:
> webkitgtk-2.5.1.tar.xz 13MB 15285 files
> 
> After:
> webkitgtk-2.5.1.tar.xz 11MB 12829 files
> 
> Still bigger than stable:
> webkitgtk-2.4.4.tar.xz 9,4MB 9994 files


I think this 1.6 megabytes is not a huge deal. :)

[Carlos Garcia Campos]

(In reply to comment #2)
> (From update of attachment 234707 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=234707&action=review
> 
> > Tools/gtk/manifest.txt:51
> > +exclude Source/autotools
> 
> This is unnecessary now, right?

That's a fix actually, it removes the trailing $

-exclude Source/autotools$
+exclude Source/autotools

to make sure it's actually excluded

> > Tools/gtk/manifest.txt:73
> > +# Inlcude only the resources we actually build
> 
> Inlcude -> Include

Oops

[Carlos Garcia Campos]

(In reply to comment #3)
> (In reply to comment #1)
> > Created an attachment (id=234707) [details] [details]
> > Patch
> > 
> > Before:
> > webkitgtk-2.5.1.tar.xz 13MB 15285 files
> > 
> > After:
> > webkitgtk-2.5.1.tar.xz 11MB 12829 files
> > 
> > Still bigger than stable:
> > webkitgtk-2.4.4.tar.xz 9,4MB 9994 files
> 
> 
> I think this 1.6 megabytes is not a huge deal. :)

Yes, much better than the 3.6MB before, but still more than what I would like TBH.

[Carlos Garcia Campos]

Created attachment 234709 [details]
Updated patch

Fix the typo

[Martin Robinson]

Comment on attachment 234707 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234707&action=review

>>> Tools/gtk/manifest.txt:51
>>> +exclude Source/autotools
>> 
>> This is unnecessary now, right?
> 
> That's a fix actually, it removes the trailing $
> 
> -exclude Source/autotools$
> +exclude Source/autotools
> 
> to make sure it's actually excluded

Sorry. My point is that Source/autotools doesn't even exist now, so it doesn't need to be excluded.

[Carlos Garcia Campos]

(In reply to comment #7)
> (From update of attachment 234707 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=234707&action=review
> 
> >>> Tools/gtk/manifest.txt:51
> >>> +exclude Source/autotools
> >> 
> >> This is unnecessary now, right?
> > 
> > That's a fix actually, it removes the trailing $
> > 
> > -exclude Source/autotools$
> > +exclude Source/autotools
> > 
> > to make sure it's actually excluded
> 
> Sorry. My point is that Source/autotools doesn't even exist now, so it doesn't need to be excluded.

Ah, you are right, it exists in my tree though, I guess because I switch between branches.

[Martin Robinson]

Comment on attachment 234707 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234707&action=review

>>>>> Tools/gtk/manifest.txt:51
>>>>> +exclude Source/autotools
>>>> 
>>>> This is unnecessary now, right?
>>> 
>>> That's a fix actually, it removes the trailing $
>>> 
>>> -exclude Source/autotools$
>>> +exclude Source/autotools
>>> 
>>> to make sure it's actually excluded
>> 
>> Sorry. My point is that Source/autotools doesn't even exist now, so it doesn't need to be excluded.
> 
> Ah, you are right, it exists in my tree though, I guess because I switch between branches.

Hopefully that won't be an issue when your patch ensuring that only files from git are included lands.

[Carlos Garcia Campos]

(In reply to comment #9)
> (From update of attachment 234707 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=234707&action=review
> 
> >>>>> Tools/gtk/manifest.txt:51
> >>>>> +exclude Source/autotools
> >>>> 
> >>>> This is unnecessary now, right?
> >>> 
> >>> That's a fix actually, it removes the trailing $
> >>> 
> >>> -exclude Source/autotools$
> >>> +exclude Source/autotools
> >>> 
> >>> to make sure it's actually excluded
> >> 
> >> Sorry. My point is that Source/autotools doesn't even exist now, so it doesn't need to be excluded.
> > 
> > Ah, you are right, it exists in my tree though, I guess because I switch between branches.
> 
> Hopefully that won't be an issue when your patch ensuring that only files from git are included lands.

Indeed

[Carlos Garcia Campos]

Created attachment 234751 [details]
Updated patch

Remove the rule to exclude autotools dir

[Carlos Garcia Campos]

Committed r171296: <http://trac.webkit.org/changeset/171296>