Summary: | [GTK] Reduce the size of the tarball generated by distcheck | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | gustavo, mrobinson, svillar | ||||||||
Priority: | P2 | Keywords: | Gtk | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2014-07-10 09:19:59 PDT
Created attachment 234707 [details]
Patch
Before:
webkitgtk-2.5.1.tar.xz 13MB 15285 files
After:
webkitgtk-2.5.1.tar.xz 11MB 12829 files
Still bigger than stable:
webkitgtk-2.4.4.tar.xz 9,4MB 9994 files
Comment on attachment 234707 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234707&action=review > Tools/gtk/manifest.txt:51 > +exclude Source/autotools This is unnecessary now, right? > Tools/gtk/manifest.txt:73 > +# Inlcude only the resources we actually build Inlcude -> Include (In reply to comment #1) > Created an attachment (id=234707) [details] > Patch > > Before: > webkitgtk-2.5.1.tar.xz 13MB 15285 files > > After: > webkitgtk-2.5.1.tar.xz 11MB 12829 files > > Still bigger than stable: > webkitgtk-2.4.4.tar.xz 9,4MB 9994 files I think this 1.6 megabytes is not a huge deal. :) (In reply to comment #2) > (From update of attachment 234707 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=234707&action=review > > > Tools/gtk/manifest.txt:51 > > +exclude Source/autotools > > This is unnecessary now, right? That's a fix actually, it removes the trailing $ -exclude Source/autotools$ +exclude Source/autotools to make sure it's actually excluded > > Tools/gtk/manifest.txt:73 > > +# Inlcude only the resources we actually build > > Inlcude -> Include Oops (In reply to comment #3) > (In reply to comment #1) > > Created an attachment (id=234707) [details] [details] > > Patch > > > > Before: > > webkitgtk-2.5.1.tar.xz 13MB 15285 files > > > > After: > > webkitgtk-2.5.1.tar.xz 11MB 12829 files > > > > Still bigger than stable: > > webkitgtk-2.4.4.tar.xz 9,4MB 9994 files > > > I think this 1.6 megabytes is not a huge deal. :) Yes, much better than the 3.6MB before, but still more than what I would like TBH. Created attachment 234709 [details]
Updated patch
Fix the typo
Comment on attachment 234707 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234707&action=review >>> Tools/gtk/manifest.txt:51 >>> +exclude Source/autotools >> >> This is unnecessary now, right? > > That's a fix actually, it removes the trailing $ > > -exclude Source/autotools$ > +exclude Source/autotools > > to make sure it's actually excluded Sorry. My point is that Source/autotools doesn't even exist now, so it doesn't need to be excluded. (In reply to comment #7) > (From update of attachment 234707 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=234707&action=review > > >>> Tools/gtk/manifest.txt:51 > >>> +exclude Source/autotools > >> > >> This is unnecessary now, right? > > > > That's a fix actually, it removes the trailing $ > > > > -exclude Source/autotools$ > > +exclude Source/autotools > > > > to make sure it's actually excluded > > Sorry. My point is that Source/autotools doesn't even exist now, so it doesn't need to be excluded. Ah, you are right, it exists in my tree though, I guess because I switch between branches. Comment on attachment 234707 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234707&action=review >>>>> Tools/gtk/manifest.txt:51 >>>>> +exclude Source/autotools >>>> >>>> This is unnecessary now, right? >>> >>> That's a fix actually, it removes the trailing $ >>> >>> -exclude Source/autotools$ >>> +exclude Source/autotools >>> >>> to make sure it's actually excluded >> >> Sorry. My point is that Source/autotools doesn't even exist now, so it doesn't need to be excluded. > > Ah, you are right, it exists in my tree though, I guess because I switch between branches. Hopefully that won't be an issue when your patch ensuring that only files from git are included lands. (In reply to comment #9) > (From update of attachment 234707 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=234707&action=review > > >>>>> Tools/gtk/manifest.txt:51 > >>>>> +exclude Source/autotools > >>>> > >>>> This is unnecessary now, right? > >>> > >>> That's a fix actually, it removes the trailing $ > >>> > >>> -exclude Source/autotools$ > >>> +exclude Source/autotools > >>> > >>> to make sure it's actually excluded > >> > >> Sorry. My point is that Source/autotools doesn't even exist now, so it doesn't need to be excluded. > > > > Ah, you are right, it exists in my tree though, I guess because I switch between branches. > > Hopefully that won't be an issue when your patch ensuring that only files from git are included lands. Indeed Created attachment 234751 [details]
Updated patch
Remove the rule to exclude autotools dir
Committed r171296: <http://trac.webkit.org/changeset/171296> |