Bug 134771

Summary: Implement Editor::fontAttributesForSelectionStart() or iOS
Product: WebKit Reporter: Enrica Casucci <enrica>
Component: HTML EditingAssignee: Enrica Casucci <enrica>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch2 rniwa: review+

Enrica Casucci
Reported 2014-07-09 10:42:19 PDT
This bug tracks the work required to implement this function for iOS.
Attachments
Patch (4.90 KB, patch)
2014-07-09 10:47 PDT, Enrica Casucci 		no flags
DetailsFormatted DiffDiff
Patch2 (4.42 KB, patch)
2014-07-09 12:00 PDT, Enrica Casucci 		rniwa: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Enrica Casucci
Comment 1 2014-07-09 10:42:41 PDT
<rdar://problem/16167838>
Enrica Casucci
Comment 2 2014-07-09 10:47:21 PDT
Created attachment 234645 [details] Patch
Enrica Casucci
Comment 3 2014-07-09 12:00:37 PDT
Created attachment 234650 [details] Patch2 removed unnecessary SOFT_LINK stuff
Ryosuke Niwa
Comment 4 2014-07-09 12:08:32 PDT
Comment on attachment 234650 [details] Patch2 View in context: https://bugs.webkit.org/attachment.cgi?id=234650&action=review > Source/WebCore/editing/ios/EditorIOS.mm:264 > + if (style->font().primaryFont()->getCTFont()) > + [result setObject:(id)style->font().primaryFont()->getCTFont() forKey:NSFontAttributeName]; We should store it in a local variable inside if () instead of calling getCTFont() twice,
Enrica Casucci
Comment 5 2014-07-09 12:12:18 PDT
Committed revision 170924.
Note You need to log in before you can comment on or make changes to this bug.