Bug 134771

Summary:

Implement Editor::fontAttributesForSelectionStart() or iOS

Product:

WebKit

Reporter:

Enrica Casucci <enrica>

Component:

HTML Editing

Assignee:

Enrica Casucci <enrica>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

iPhone / iPad

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch2	rniwa: review+

Description Enrica Casucci 2014-07-09 10:42:19 PDT

This bug tracks the work required to implement this function for iOS.

Comment 1 Enrica Casucci 2014-07-09 10:42:41 PDT

<rdar://problem/16167838>

Comment 2 Enrica Casucci 2014-07-09 10:47:21 PDT

Created attachment 234645 [details]
Patch

Comment 3 Enrica Casucci 2014-07-09 12:00:37 PDT

Created attachment 234650 [details]
Patch2

removed unnecessary SOFT_LINK stuff

Comment 4 Ryosuke Niwa 2014-07-09 12:08:32 PDT

Comment on attachment 234650 [details]
Patch2

View in context: https://bugs.webkit.org/attachment.cgi?id=234650&action=review

> Source/WebCore/editing/ios/EditorIOS.mm:264
> +    if (style->font().primaryFont()->getCTFont())
> +        [result setObject:(id)style->font().primaryFont()->getCTFont() forKey:NSFontAttributeName];

We should store it in a local variable inside if () instead of calling getCTFont() twice,

Comment 5 Enrica Casucci 2014-07-09 12:12:18 PDT

Committed revision 170924.