| Summary: | [Win] Remove use of 'grep' in build steps | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||||||
| Component: | Tools / Tests | Assignee: | Brent Fulgham <bfulgham> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bfulgham, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 234642 [details]
Patch
Comment on attachment 234642 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234642&action=review > Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCorePreBuild.cmd:4 > +if exist "%CONFIGURATIONBUILDDIR%\buildfailed" perl -wnne "if (/XX%PROJECTNAME%XX/) { print } else { exit 1}" "%CONFIGURATIONBUILDDIR%\buildfailed" I need to correct "1}" to be "1 }" Created attachment 234644 [details]
Patch
Comment on attachment 234644 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234644&action=review > Source/WebCore/WebCore.vcxproj/WebCoreGenerated.make:14 > + if exist "%ConfigurationBuildDir%\buildfailed" del "%ConfigurationBuildDir%\buildfailed" Looks like line endings for this file are off. Created attachment 234646 [details]
Patch
Comment on attachment 234646 [details]
Patch
rs=me
Committed r170922: <http://trac.webkit.org/changeset/170922> |
To reduce dependency on Cygwin utilities, switch from using command line 'grep' to the equivalent Perl program: perl -wnne "if (/XX%PROJECTNAME%XX/) { print } else { exit 1}" "%CONFIGURATIONBUILDDIR%\buildfailed" .... is equivalent to: grep XX%PROJECTNAME%XX "%CONFIGURATIONBUILDDIR%\buildfailed"