Bug 134768

Summary: [MSE] http/tests/media/media-source/mediasource-remove.html is failing
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, commit-queue, eric.carlson, glenn, ltilve, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric.carlson: review+

Description Jer Noble 2014-07-09 09:05:31 PDT 
[MSE] http/tests/media/media-source/mediasource-remove.html is failing
Comment 1 Jer Noble 2014-07-09 09:06:50 PDT 
Created attachment 234641 [details]
Patch
Comment 2 Eric Carlson 2014-07-09 10:35:08 PDT 
Comment on attachment 234641 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234641&action=review

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:579
> +        // and the next sync sample frame are removed. But we must start from the first sample in decode order, not
> +        // presentation order.

Having this comment just before the code that calculates and compares removePresentationStart really confused me at first. Maybe put it after?
Comment 3 Jer Noble 2014-07-09 13:51:20 PDT 
Comment on attachment 234641 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234641&action=review

>> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:579
>> +        // presentation order.
> 
> Having this comment just before the code that calculates and compares removePresentationStart really confused me at first. Maybe put it after?

Sure.
Comment 4 Jer Noble 2014-07-09 14:37:43 PDT 
Committed r170932: <http://trac.webkit.org/changeset/170932>