Bug 134757

Summary: mutable pointers from const methods, timeContainer()
Product: WebKit Reporter: Jeongeun Kim <je_julie.kim>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, dbates, d-r, fmalita, gyuyoung.kim, pdr, rniwa, schenney, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jeongeun Kim
Reported 2014-07-09 03:53:33 PDT
According to https://lists.webkit.org/pipermail/webkit-dev/2012-October/022580.html, We avoid return mutable pointers from const methods. timeContainer() doesn't need to be const method.
Attachments
Patch (2.13 KB, patch)
2014-07-09 04:04 PDT, Jeongeun Kim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeongeun Kim
Comment 1 2014-07-09 04:04:14 PDT
Created attachment 234625 [details] Patch
Jeongeun Kim
Comment 2 2014-07-09 04:11:12 PDT
After I discussed const method with Daniel Bates on IRC, I've checked timeContainer() const method. I think that API doesn't need to be const method. Please take a look.
WebKit Commit Bot
Comment 3 2014-07-16 08:03:57 PDT
Comment on attachment 234625 [details] Patch Clearing flags on attachment: 234625 Committed r171144: <http://trac.webkit.org/changeset/171144>
WebKit Commit Bot
Comment 4 2014-07-16 08:04:02 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 5 2014-07-16 09:44:56 PDT
This commit has added svn:executable bit to several files. I removed it in <http://trac.webkit.org/r171147>. Any idea how it got there? It was not in the patch, and the patch was landed by commit queue. Did someone break commit queue recently?
Alexey Proskuryakov
Comment 6 2014-07-16 09:48:07 PDT
Actually, it was in the patch: > old mode 100644 > new mode 100755
Jeongeun Kim
Comment 7 2014-07-16 17:52:17 PDT
Sorry for the inconvenience. I checked it with ap on IRC. I'll check patch with that mode information next time. Thanks,
Note You need to log in before you can comment on or make changes to this bug.