Bug 134757 - mutable pointers from const methods, timeContainer()
Summary: mutable pointers from const methods, timeContainer()
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2014-07-09 03:53 PDT by Jeongeun Kim
Modified: 2014-07-16 17:52 PDT (History)
10 users (show)

See Also:

Patch (2.13 KB, patch)
2014-07-09 04:04 PDT, Jeongeun Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeongeun Kim 2014-07-09 03:53:33 PDT
According to https://lists.webkit.org/pipermail/webkit-dev/2012-October/022580.html,
We avoid return mutable pointers from const methods.
timeContainer() doesn't need to be const method.
Comment 1 Jeongeun Kim 2014-07-09 04:04:14 PDT
Created attachment 234625 [details]
Comment 2 Jeongeun Kim 2014-07-09 04:11:12 PDT
After I discussed const method with Daniel Bates on IRC,
I've checked timeContainer() const method.
I think that API doesn't need to be const method.
Please take a look.
Comment 3 WebKit Commit Bot 2014-07-16 08:03:57 PDT
Comment on attachment 234625 [details]

Clearing flags on attachment: 234625

Committed r171144: <http://trac.webkit.org/changeset/171144>
Comment 4 WebKit Commit Bot 2014-07-16 08:04:02 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2014-07-16 09:44:56 PDT
This commit has added svn:executable bit to several files. I removed it in <http://trac.webkit.org/r171147>.

Any idea how it got there? It was not in the patch, and the patch was landed by commit queue. Did someone break commit queue recently?
Comment 6 Alexey Proskuryakov 2014-07-16 09:48:07 PDT
Actually, it was in the patch:

> old mode 100644
> new mode 100755
Comment 7 Jeongeun Kim 2014-07-16 17:52:17 PDT
Sorry for the inconvenience. I checked it with ap on IRC. 
I'll check patch with that mode information next time.