| Summary: | [iOS][WK2] subviews of the unscaled view drift out during CA animations | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||
| Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, enrica | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Benjamin Poulain
2014-07-08 19:31:10 PDT
Created attachment 234618 [details]
Patch
Attachment 234618 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:356: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:356: Missing space before { [whitespace/braces] [5]
Total errors found: 2 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 234618 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234618&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:350 > + if ([UIView _isInAnimationBlock] && _page->editorState().selectionIsNone && ![_highlightView superview]) { For landing, I'll remove [_highlightView superview] and do [self _cancelInteraction] instead. Otherwise the tap highlight animation can still cause the ugly caret issue. Comment on attachment 234618 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234618&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h:104 > + RetainPtr<UIView> _unscaledView; Fixme: Simon would prefer the name interactionViewsContainerView. Comment on attachment 234618 [details]
Patch
Looks good to me.
Committed r170926: <http://trac.webkit.org/changeset/170926> |