Bug 134745

Summary: [Win] Implement auto-version as a Perl program
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: Tools / TestsAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ddkilzer, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch
none
Patch ddkilzer: review+

Brent Fulgham
Reported 2014-07-08 15:19:40 PDT
Reduce reliance on Cygwin and Bash behaviors by writing the 'auto-version' utility as a Perl script, rather than a bash script. This will make it easier to drive the build using native Windows-based utilities rather than requiring Cygwin.
Attachments
Patch (8.59 KB, patch)
2014-07-08 15:24 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (8.75 KB, patch)
2014-07-08 16:21 PDT, Brent Fulgham 		ddkilzer: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2014-07-08 15:24:52 PDT
Created attachment 234600 [details] Patch
Radar WebKit Bug Importer
Comment 2 2014-07-08 15:25:09 PDT
<rdar://problem/17597791>
Radar WebKit Bug Importer
Comment 3 2014-07-08 15:25:11 PDT
<rdar://problem/17597801>
Brent Fulgham
Comment 4 2014-07-08 16:21:47 PDT
Created attachment 234605 [details] Patch
David Kilzer (:ddkilzer)
Comment 5 2014-07-08 16:55:44 PDT
Comment on attachment 234605 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234605&action=review r=me > WebKitLibraries/win/tools/scripts/auto-version.pl:98 > +my $VARIANT_VERSION =$BUILD_TINY_VERSION; Nit: Space after '='. > WebKitLibraries/win/tools/scripts/auto-version.pl:104 > +if (!defined $ENVIRONMENT_VERSION) { Technically, the equivalent to "-z" would be: if (!$ENVIRONMENT_VERSION) { Not sure if that matters. (Defined returns true if the string is empty, but "!" will not, IIRC.)
Brent Fulgham
Comment 6 2014-07-08 16:58:53 PDT
(In reply to comment #5) > (From update of attachment 234605 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=234605&action=review > > r=me > > > WebKitLibraries/win/tools/scripts/auto-version.pl:98 > > +my $VARIANT_VERSION =$BUILD_TINY_VERSION; > > Nit: Space after '='. Done. > > WebKitLibraries/win/tools/scripts/auto-version.pl:104 > > +if (!defined $ENVIRONMENT_VERSION) { > > Technically, the equivalent to "-z" would be: > > if (!$ENVIRONMENT_VERSION) { > > Not sure if that matters. (Defined returns true if the string is empty, but "!" will not, IIRC.) I'll switch to your version. It may not matter, but I'd like to be as close to the bash version as possible in behavior.
Brent Fulgham
Comment 7 2014-07-08 16:59:35 PDT
This EWS bot seems broken. The file builds fine locally. I will land it and watch the bots and correct as necessary.
Brent Fulgham
Comment 8 2014-07-08 17:02:38 PDT
Committed r170905: <http://trac.webkit.org/changeset/170905>
Note You need to log in before you can comment on or make changes to this bug.