Bug 134740

Summary: [iOS] caption size is sometimes incorrect in fullscreen
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch. none

Description Eric Carlson 2014-07-08 13:08:30 PDT 
The font sized used for captions sometimes does not change immediately when entering full screen.
Comment 1 Eric Carlson 2014-07-08 13:34:20 PDT 
Created attachment 234589 [details]
Proposed patch.
Comment 2 Jer Noble 2014-07-08 13:53:58 PDT 
Comment on attachment 234589 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=234589&action=review

r=me

> Source/WebCore/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * Modules/mediacontrols/MediaControlsHost.cpp:

Nit: no description of the problem and how this patch fixes it?
Comment 3 Eric Carlson 2014-07-09 10:18:21 PDT 
(In reply to comment #2)
> (From update of attachment 234589 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=234589&action=review
> 
> r=me
> 
> > Source/WebCore/ChangeLog:8
> > +        Reviewed by NOBODY (OOPS!).
> > +
> > +        * Modules/mediacontrols/MediaControlsHost.cpp:
> 
> Nit: no description of the problem and how this patch fixes it?

Fixed.
Comment 4 Eric Carlson 2014-07-09 10:18:58 PDT 
Committed r170920: http://trac.webkit.org/changeset/170920