Bug 134739

Summary: [ftlopt] Move Flush(SetLocal) store elimination to StrengthReductionPhase
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 134677    
Attachments:
Description Flags
the patch
none
the patch
none
the patch mhahnenberg: review+

Filip Pizlo
Reported 2014-07-08 12:41:56 PDT
I'm going to streamline CSE around clobberize(), and so Flush(SetLocal) store elimination wouldn't belong anymore. It doesn't quite belong anywhere, which means that it belongs in StrengthReductionPhase.
Attachments
the patch (8.53 KB, patch)
2014-07-08 12:50 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (9.95 KB, patch)
2014-07-08 13:25 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (9.83 KB, patch)
2014-07-08 20:35 PDT, Filip Pizlo 		mhahnenberg: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-07-08 12:50:50 PDT
Created attachment 234584 [details] the patch Not yet ready for review because I'm still testing it
Filip Pizlo
Comment 2 2014-07-08 13:25:59 PDT
Created attachment 234588 [details] the patch
Filip Pizlo
Comment 3 2014-07-08 20:35:31 PDT
Created attachment 234614 [details] the patch
Mark Hahnenberg
Comment 4 2014-07-09 10:50:18 PDT
Comment on attachment 234614 [details] the patch r=me
Filip Pizlo
Comment 5 2014-07-09 14:17:12 PDT
Landed in http://trac.webkit.org/changeset/170929
Note You need to log in before you can comment on or make changes to this bug.