Bug 134733

Summary: Add SharedBuffer::wrapCFDataArray() and use it
Product: WebKit Reporter: Pratik Solanki <psolanki>
Component: WebCore Misc.Assignee: Pratik Solanki <psolanki>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, beidson, bfulgham, kling, koivisto, psolanki
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 134560    
Attachments:
Description Flags
Patch koivisto: review+

Pratik Solanki
Reported 2014-07-08 10:48:35 PDT
Add SharedBuffer::wrapCFDataArray() similar to SharedBuffer::wrapCFData().
Attachments
Patch (10.32 KB, patch)
2014-07-08 10:50 PDT, Pratik Solanki 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pratik Solanki
Comment 1 2014-07-08 10:50:26 PDT
Created attachment 234573 [details] Patch
Antti Koivisto
Comment 2 2014-07-09 11:56:30 PDT
Comment on attachment 234573 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234573&action=review > Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm:200 > + m_handle->client()->didReceiveBuffer(m_handle, SharedBuffer::wrapCFDataArrat(reinterpret_cast<CFArrayRef>(dataArray)), -1); Typo wrapCFDataArrat Is this change unnecessary as it doesn't seem to be compiled?
Pratik Solanki
Comment 3 2014-07-09 14:20:18 PDT
Committed r170930: <http://trac.webkit.org/changeset/170930>
Brent Fulgham
Comment 4 2014-07-09 17:03:55 PDT
This change broke the Windows build. Working on a fix.
Brent Fulgham
Comment 5 2014-07-09 17:23:33 PDT
A follow-up patch is needed to unbreak the Windows build: http://trac.webkit.org/changeset/170939
Note You need to log in before you can comment on or make changes to this bug.