Bug 134733

Summary:

Add SharedBuffer::wrapCFDataArray() and use it

Product:

WebKit

Reporter:

Pratik Solanki <psolanki>

Component:

WebCore Misc.

Assignee:

Pratik Solanki <psolanki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, beidson, bfulgham, kling, koivisto, psolanki

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

134560

Attachments:

Description	Flags
Patch	koivisto: review+

Description Pratik Solanki 2014-07-08 10:48:35 PDT

Add SharedBuffer::wrapCFDataArray() similar to SharedBuffer::wrapCFData().

Comment 1 Pratik Solanki 2014-07-08 10:50:26 PDT

Created attachment 234573 [details]
Patch

Comment 2 Antti Koivisto 2014-07-09 11:56:30 PDT

Comment on attachment 234573 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234573&action=review

> Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm:200
> +    m_handle->client()->didReceiveBuffer(m_handle, SharedBuffer::wrapCFDataArrat(reinterpret_cast<CFArrayRef>(dataArray)), -1);

Typo wrapCFDataArrat

Is this change unnecessary as it doesn't seem to be compiled?

Comment 3 Pratik Solanki 2014-07-09 14:20:18 PDT

Committed r170930: <http://trac.webkit.org/changeset/170930>

Comment 4 Brent Fulgham 2014-07-09 17:03:55 PDT

This change broke the Windows build. Working on a fix.

Comment 5 Brent Fulgham 2014-07-09 17:23:33 PDT

A follow-up patch is needed to unbreak the Windows build:

http://trac.webkit.org/changeset/170939