Bug 134711

Summary:

WKProcessPoolConfigurationPrivate's maximumProcessCount property has no effect

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

WebKit2

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, mitz, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	mitz: review+

Description Tim Horton 2014-07-07 19:06:52 PDT

Because nothing ever reads from it!

It would also be nice if MiniBrowser had a maximumProcessCount=1 mode; frequently useful for debugging things where having two pages in one process is important.

Comment 1 Tim Horton 2014-07-07 20:00:30 PDT

Huh, I see no indication that there's a process cap by default. I thought it was 20 or some such?

Comment 2 Tim Horton 2014-07-08 12:19:57 PDT

Created attachment 234581 [details]
patch

Comment 3 mitz 2014-07-08 12:22:38 PDT

Comment on attachment 234581 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234581&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:173
> +    _context->setMaximumNumberOfProcesses(configuration.maximumProcessCount);

Everywhere else in this method we use the instance variable _configuration, not the parameter.

Comment 4 Tim Horton 2014-07-08 12:28:43 PDT

http://trac.webkit.org/changeset/170893