Bug 134701

Summary: [UI-side compositing] Support reflections on custom layers like video
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Simon Fraser (smfr)
Reported 2014-07-07 16:22:41 PDT
[UI-side compositing] Support reflections on custom layers like video
Attachments
Patch (27.52 KB, patch)
2014-07-07 16:31 PDT, Simon Fraser (smfr) 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2014-07-07 16:31:07 PDT
Created attachment 234525 [details] Patch
Tim Horton
Comment 2 2014-07-07 16:38:44 PDT
Comment on attachment 234525 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234525&action=review > Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm:183 > + if ([layer isKindOfClass:[NSClassFromString(@"WebGLLayer") class]]) we talked about this > Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm:221 > + // We don't create PlatformCALayerMac's wrapped around WebGLLayers. weird apostrophe > Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:50 > + PlatformCALayerRemoteCustom(WebCore::PlatformCALayer::LayerType, PlatformLayer*, WebCore::PlatformCALayerClient* owner, RemoteLayerTreeContext&); star's on the wrong side
Simon Fraser (smfr)
Comment 3 2014-07-07 16:46:09 PDT
https://trac.webkit.org/r170864
Note You need to log in before you can comment on or make changes to this bug.