Summary: | [UI-side compositing] Support reflections on custom layers like video | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dino, simon.fraser, thorton | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2014-07-07 16:22:41 PDT
Created attachment 234525 [details]
Patch
Comment on attachment 234525 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234525&action=review > Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm:183 > + if ([layer isKindOfClass:[NSClassFromString(@"WebGLLayer") class]]) we talked about this > Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm:221 > + // We don't create PlatformCALayerMac's wrapped around WebGLLayers. weird apostrophe > Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:50 > + PlatformCALayerRemoteCustom(WebCore::PlatformCALayer::LayerType, PlatformLayer*, WebCore::PlatformCALayerClient* owner, RemoteLayerTreeContext&); star's on the wrong side |