| Summary: | Ensure we compute the height of replaced elements to 'auto' when appropriate. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Bem Jones-Bey <bjonesbe> | ||||||||
| Component: | Layout and Rendering | Assignee: | Bem Jones-Bey <bjonesbe> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Bem Jones-Bey
2014-07-07 16:05:27 PDT
This is based on two Blink commits: https://codereview.chromium.org/347053007 https://codereview.chromium.org/359673003 Created attachment 234566 [details]
Patch
Comment on attachment 234566 [details] Patch Attachment 234566 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6155536265379840 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html Created attachment 234570 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 234566 [details] Patch Attachment 234566 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4982631162707968 New failing tests: media/video-ended-event-negative-playback.html Created attachment 234578 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Both of those failed tests run fine for me locally on 10.9.4. (both Debug and Release builds) I don't currently see any way that this change could have caused these tests to timeout. Comment on attachment 234566 [details]
Patch
r=me
Comment on attachment 234566 [details]
Patch
Lets roll the dice with the CQ.
Comment on attachment 234566 [details] Patch Clearing flags on attachment: 234566 Committed r170895: <http://trac.webkit.org/changeset/170895> All reviewed patches have been landed. Closing bug. |