Bug 134697

Summary:

Remove misleadingly-named Font::isSVGFont()

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, d-r, enrica, esprehn+autocc, fmalita, glenn, gyuyoung.kim, jonlee, kondapallykalyan, pdr, schenney, sergio, simon.fraser, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Myles C. Maxfield 2014-07-07 15:10:24 PDT

Remove misleadingly-named Font::isSVGFont()

Comment 1 Myles C. Maxfield 2014-07-07 15:13:02 PDT

Created attachment 234516 [details]
Patch

Comment 2 Darin Adler 2014-07-07 16:17:05 PDT

Comment on attachment 234516 [details]
Patch

What guarantees that primaryFont is non-null at all these call sites?

Comment 3 Myles C. Maxfield 2014-07-07 16:44:26 PDT

I don't believe there is any, other than that the existing code already dereferences these pointers. Do you have an opinion about how I should do this differently?

Comment 4 WebKit Commit Bot 2014-07-07 19:27:38 PDT

Comment on attachment 234516 [details]
Patch

Clearing flags on attachment: 234516

Committed r170871: <http://trac.webkit.org/changeset/170871>

Comment 5 WebKit Commit Bot 2014-07-07 19:27:43 PDT

All reviewed patches have been landed.  Closing bug.