Bug 134695

Summary: add css jit profiler
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: CSSAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, benjamin, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kangil.han, macpherson, menard
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 134749    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2014-07-07 14:53:43 PDT
Profiling the css jit compiler is useful to know where we need to improve.
Attachments
Patch (9.06 KB, patch)
2014-07-07 14:54 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (9.45 KB, patch)
2014-07-07 15:25 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2014-07-07 14:54:27 PDT
Created attachment 234513 [details] Patch
Alex Christensen
Comment 2 2014-07-07 15:25:45 PDT
Created attachment 234519 [details] Patch
WebKit Commit Bot
Comment 3 2014-07-08 14:48:18 PDT
Comment on attachment 234519 [details] Patch Clearing flags on attachment: 234519 Committed r170894: <http://trac.webkit.org/changeset/170894>
WebKit Commit Bot
Comment 4 2014-07-08 14:48:22 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 5 2014-07-08 17:41:30 PDT
Re-opened since this is blocked by bug 134749
Alex Christensen
Comment 6 2014-07-08 22:40:45 PDT
Comment on attachment 234519 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234519&action=review > Source/WebCore/cssjit/SelectorCompiler.h:34 > +#define CSS_SELECTOR_JIT_PROFILING 1 Here's the problem. This should be 0. I'll recommit this tomorrow with 0 and watch the bots.
Alex Christensen
Comment 7 2014-07-09 10:45:27 PDT
Comment on attachment 234519 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234519&action=review > Source/WebCore/css/RuleSet.cpp:143 > +#if CSS_SELECTOR_JIT_PROFILING Ah, this should be ENABLE(CSS_SELECTOR_JIT) && CSS_SELECTOR_JIT_PROFILING > Source/WebCore/dom/SelectorQuery.h:59 > +#if CSS_SELECTOR_JIT_PROFILING this, too.
Alex Christensen
Comment 8 2014-07-09 10:51:22 PDT
Re-committed to http://trac.webkit.org/changeset/170921 and watching bots...
Note You need to log in before you can comment on or make changes to this bug.