Bug 134695

Summary: add css jit profiler
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: CSSAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, benjamin, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kangil.han, macpherson, menard
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 134749    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description Alex Christensen 2014-07-07 14:53:43 PDT 
Profiling the css jit compiler is useful to know where we need to improve.
Comment 1 Alex Christensen 2014-07-07 14:54:27 PDT 
Created attachment 234513 [details]
Patch
Comment 2 Alex Christensen 2014-07-07 15:25:45 PDT 
Created attachment 234519 [details]
Patch
Comment 3 WebKit Commit Bot 2014-07-08 14:48:18 PDT 
Comment on attachment 234519 [details]
Patch

Clearing flags on attachment: 234519

Committed r170894: <http://trac.webkit.org/changeset/170894>
Comment 4 WebKit Commit Bot 2014-07-08 14:48:22 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Commit Bot 2014-07-08 17:41:30 PDT 
Re-opened since this is blocked by bug 134749
Comment 6 Alex Christensen 2014-07-08 22:40:45 PDT 
Comment on attachment 234519 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234519&action=review

> Source/WebCore/cssjit/SelectorCompiler.h:34
> +#define CSS_SELECTOR_JIT_PROFILING 1

Here's the problem.  This should be 0.  I'll recommit this tomorrow with 0 and watch the bots.
Comment 7 Alex Christensen 2014-07-09 10:45:27 PDT 
Comment on attachment 234519 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234519&action=review

> Source/WebCore/css/RuleSet.cpp:143
> +#if CSS_SELECTOR_JIT_PROFILING

Ah, this should be ENABLE(CSS_SELECTOR_JIT) && CSS_SELECTOR_JIT_PROFILING

> Source/WebCore/dom/SelectorQuery.h:59
> +#if CSS_SELECTOR_JIT_PROFILING

this, too.
Comment 8 Alex Christensen 2014-07-09 10:51:22 PDT 
Re-committed to http://trac.webkit.org/changeset/170921 and watching bots...