Summary: | fix nested function crash on iOS | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
Component: | WebGL | Assignee: | Alex Christensen <achristensen> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, dino, kondapallykalyan, noam, roger_fong | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
URL: | https://www.khronos.org/registry/webgl/sdk/tests/conformance/glsl/bugs/nested-functions-should-not-crash.html | ||||||
Bug Depends on: | 134748 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Alex Christensen
2014-07-07 10:13:28 PDT
Created attachment 234491 [details]
Patch
Comment on attachment 234491 [details]
Patch
r=me
Is there a performance cost to this limit?
(In reply to comment #3) > (From update of attachment 234491 [details]) > r=me > > Is there a performance cost to this limit? If someone has a shader with more than 256 nested functions, it will no longer compile. I don't think there's a performance hit because this only changes the shader validator, and I think the call depth is counted anyway. It just wasn't used without this change. Comment on attachment 234491 [details] Patch Clearing flags on attachment: 234491 Committed r170849: <http://trac.webkit.org/changeset/170849> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 134748 this did not break the build and it was not rolled out. reclosing. |