Bug 134678

Summary:

Some of the WKPreferences (API) property getters read like questions

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

WebKit2

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, darin, mitz, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	mitz: review+

Description Tim Horton 2014-07-06 23:07:28 PDT

Specifically, Dan calls these three out in https://bugs.webkit.org/show_bug.cgi?id=134645#c8:

@property (nonatomic, getter=isJavaScriptEnabled) BOOL javaScriptEnabled;
@property (nonatomic, getter=isJavaEnabled) BOOL javaEnabled;
@property (nonatomic, getter=arePlugInsEnabled) BOOL plugInsEnabled;

See the discussion in that bug for potential alternatives.

Comment 1 Radar WebKit Bug Importer 2014-07-07 11:05:41 PDT

<rdar://problem/17576847>

Comment 2 Anders Carlsson 2014-07-07 12:06:07 PDT

Created attachment 234500 [details]
Patch

Comment 3 Anders Carlsson 2014-07-07 12:47:48 PDT

Created attachment 234502 [details]
Patch

Comment 4 Anders Carlsson 2014-07-07 12:52:46 PDT

Committed r170853: <http://trac.webkit.org/changeset/170853>

Comment 5 Darin Adler 2014-07-07 15:41:39 PDT

You silently fixed incorrect header documentation too. Was that intentional?