Bug 134671

Summary:

WK2 Gamepad layout test support

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

Tools / Tests

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, ap, buildbot, commit-queue, dino, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=161056

Bug Depends on:

Bug Blocks:

134076

Attachments:

Description	Flags
Patch v1 - For EWS, not ready for review	none
Patch v2 - Better feature guards	none
Patch	none
Patch	none
Archive of layout-test-results from ews104 for mac-yosemite-wk2	none
Patch	none
Patch	none
Archive of layout-test-results from ews107 for mac-yosemite-wk2	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Brady Eidson

Reported 2014-07-06 17:18:19 PDT

Gamepad LayoutTest support While we won't be able to automatically test physical gamepad connects/disconnects, virtual ones are doable. We need to write a dummy GamepadProvider with a javascript interface that lets us test the Gamepad DOM mechanism.

Attachments
Patch v1 - For EWS, not ready for review (38.99 KB, patch) 2014-09-10 14:45 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch v2 - Better feature guards (39.02 KB, patch) 2014-09-10 16:28 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (98.28 KB, patch) 2016-08-22 14:08 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (99.28 KB, patch) 2016-08-22 15:10 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (1.01 MB, application/zip) 2016-08-22 16:02 PDT, Build Bot	no flags	Details
Patch (99.28 KB, patch) 2016-08-22 16:25 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (98.69 KB, patch) 2016-08-22 16:49 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (942.15 KB, application/zip) 2016-08-22 17:43 PDT, Build Bot	no flags	Details
Patch (100.31 KB, patch) 2016-08-23 09:03 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (99.76 KB, patch) 2016-08-23 09:26 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (99.45 KB, patch) 2016-08-23 09:29 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (99.47 KB, patch) 2016-08-23 09:36 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (99.92 KB, patch) 2016-08-23 09:49 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (12) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2014-09-08 16:06:16 PDT

Have a patch in progress on this I hope to get uploaded tomorrow.

Brady Eidson

Comment 2 2014-09-10 14:45:41 PDT

Created attachment 237906 [details] Patch v1 - For EWS, not ready for review

Brady Eidson

Comment 3 2014-09-10 16:28:49 PDT

Created attachment 237915 [details] Patch v2 - Better feature guards

Brady Eidson

Comment 4 2016-08-09 11:33:38 PDT

This approach is semi-outdated and will be revisited soon.

Brady Eidson

Comment 5 2016-08-22 13:49:23 PDT

Retitling: WK2 Gamepad layout test support

Brady Eidson

Comment 6 2016-08-22 14:08:31 PDT

Created attachment 286618 [details] Patch

Alex Christensen

Comment 7 2016-08-22 14:17:31 PDT

Comment on attachment 286618 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286618&action=review > Source/WebCore/testing/MockGamepadProvider.h:67 > + bool m_shouldScheduleActivityCallback; { true }

Brady Eidson

Comment 8 2016-08-22 15:10:53 PDT

Created attachment 286628 [details] Patch

Build Bot

Comment 9 2016-08-22 16:02:39 PDT

Comment on attachment 286628 [details] Patch Attachment 286628 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1923316 New failing tests: fast/dom/navigator-detached-no-crash.html

Build Bot

Comment 10 2016-08-22 16:02:43 PDT

Created attachment 286634 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Brady Eidson

Comment 11 2016-08-22 16:25:03 PDT

Created attachment 286637 [details] Patch

Brady Eidson

Comment 12 2016-08-22 16:49:33 PDT

Created attachment 286638 [details] Patch

Build Bot

Comment 13 2016-08-22 17:43:10 PDT

Comment on attachment 286638 [details] Patch Attachment 286638 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1923975 New failing tests: fast/dom/navigator-detached-no-crash.html

Build Bot

Comment 14 2016-08-22 17:43:13 PDT

Created attachment 286643 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Alex Christensen

Comment 15 2016-08-22 23:07:56 PDT

Comment on attachment 286638 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286638&action=review Looks pretty good. EWS still not happy. Will Check in the morning > Source/WebKit2/Shared/Gamepad/GamepadData.cpp:36 > +GamepadData::GamepadData(unsigned index, const Vector<double>& axisValues, const Vector<double>& buttonValues) Could we make this take a Vector&&? > Tools/WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:28 > +LD_RUNPATH_SEARCH_PATHS = "@loader_path"; What's this? > Tools/WebKitTestRunner/TestInvocation.cpp:689 > + :(

Brady Eidson

Comment 16 2016-08-23 09:03:09 PDT

Created attachment 286716 [details] Patch

Brady Eidson

Comment 17 2016-08-23 09:26:30 PDT

Created attachment 286719 [details] Patch

Brady Eidson

Comment 18 2016-08-23 09:28:32 PDT

(In reply to comment #15) > Comment on attachment 286638 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=286638&action=review > > Looks pretty good. EWS still not happy. Will Check in the morning > > > Source/WebKit2/Shared/Gamepad/GamepadData.cpp:36 > > +GamepadData::GamepadData(unsigned index, const Vector<double>& axisValues, const Vector<double>& buttonValues) > > Could we make this take a Vector&&? Would have no benefit. > > > Tools/WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:28 > > +LD_RUNPATH_SEARCH_PATHS = "@loader_path"; > > What's this? xcode nonsense to get the UI Process linking with WebCoreTestSupport. > > Tools/WebKitTestRunner/TestInvocation.cpp:689 > > + > > :( :(

Brady Eidson

Comment 19 2016-08-23 09:29:22 PDT

Created attachment 286720 [details] Patch

Brady Eidson

Comment 20 2016-08-23 09:36:38 PDT

Created attachment 286721 [details] Patch

Brady Eidson

Comment 21 2016-08-23 09:49:40 PDT

Created attachment 286722 [details] Patch

WebKit Commit Bot

Comment 22 2016-08-23 12:42:49 PDT

Comment on attachment 286722 [details] Patch Clearing flags on attachment: 286722 Committed r204853: <http://trac.webkit.org/changeset/204853>

WebKit Commit Bot

Comment 23 2016-08-23 12:42:55 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.