Bug 134655

Summary: Fast path for casting JSValue to JSDocument*.
Product: WebKit Reporter: Andreas Kling <kling>
Component: BindingsAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cgarcia, commit-queue, esprehn+autocc, ggaren, kangil.han, kling, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch II
none
Patch II none

Description Andreas Kling 2014-07-05 11:56:29 PDT 
Fast path for casting JSValue to JSDocument*.
Comment 1 Andreas Kling 2014-07-05 11:56:54 PDT 
Created attachment 234445 [details]
Patch
Comment 2 Antti Koivisto 2014-07-06 10:59:10 PDT 
Comment on attachment 234445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234445&action=review

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:20760
> +				ADDA94BF19686F8000453029 /* JSDocumentCustom.h */,

You should probably include this file to the patch too.
Comment 3 Andreas Kling 2015-01-19 16:39:11 PST 
Created attachment 244937 [details]
Patch II
Comment 4 Andreas Kling 2015-01-19 16:48:51 PST 
Created attachment 244938 [details]
Patch II
Comment 5 WebKit Commit Bot 2015-01-20 15:10:10 PST 
Comment on attachment 244938 [details]
Patch II

Clearing flags on attachment: 244938

Committed r178758: <http://trac.webkit.org/changeset/178758>
Comment 6 WebKit Commit Bot 2015-01-20 15:10:18 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Andreas Kling 2015-01-21 10:15:19 PST 
perf.webkit.org says this was a ~4% progression on Bindings/get-element-by-id

<https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22mac-mountainlion%22%2C%22Bindings%2Fget-element-by-id%3ARuns%22%5D%5D&zoom=%5B1421575570203%2C1421795645667.8208%5D>