Bug 134647

Summary: Generate isMathMLFoo() toMathMLFoo() by using NODE_TYPE_CASTS macro and generateTypeHelpers
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebCore Misc.Assignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, dbarton, fred.wang, kling, mrobinson, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 134653    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 none

Gyuyoung Kim
Reported 2014-07-05 01:32:09 PDT
Though there is macro and generation tag for toFoo() and isFoo(), MathML hasn't used those things.
Attachments
Patch (3.06 KB, patch)
2014-07-05 01:36 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (3.35 KB, patch)
2014-07-05 03:01 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (2.91 KB, patch)
2014-07-06 05:41 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (617.36 KB, application/zip)
2014-07-06 06:44 PDT, Build Bot 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2014-07-05 01:36:04 PDT
Created attachment 234435 [details] Patch
Gyuyoung Kim
Comment 2 2014-07-05 03:01:26 PDT
Created attachment 234438 [details] Patch
WebKit Commit Bot
Comment 3 2014-07-05 03:03:31 PDT
Attachment 234438 [details] did not pass style-queue: ERROR: Source/WebCore/mathml/MathMLElement.h:84: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gyuyoung Kim
Comment 4 2014-07-05 08:27:17 PDT
CC'ing Kling. could you take a look ?
WebKit Commit Bot
Comment 5 2014-07-05 10:36:25 PDT
Comment on attachment 234438 [details] Patch Clearing flags on attachment: 234438 Committed r170825: <http://trac.webkit.org/changeset/170825>
WebKit Commit Bot
Comment 6 2014-07-05 10:36:29 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 7 2014-07-05 10:55:28 PDT
Re-opened since this is blocked by bug 134653
Gyuyoung Kim
Comment 8 2014-07-06 05:41:31 PDT
Created attachment 234455 [details] Patch
WebKit Commit Bot
Comment 9 2014-07-06 05:44:13 PDT
Attachment 234455 [details] did not pass style-queue: ERROR: Source/WebCore/mathml/MathMLElement.h:86: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 10 2014-07-06 06:44:18 PDT
Comment on attachment 234455 [details] Patch Attachment 234455 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5388528389193728 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html
Build Bot
Comment 11 2014-07-06 06:44:21 PDT
Created attachment 234456 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Gyuyoung Kim
Comment 12 2014-07-06 07:00:23 PDT
(In reply to comment #10) > (From update of attachment 234455 [details]) > Attachment 234455 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://webkit-queues.appspot.com/results/5388528389193728 > > New failing tests: > media/W3C/video/networkState/networkState_during_loadstart.html Looks unrelated.
Gyuyoung Kim
Comment 13 2014-07-06 07:01:13 PDT
Comment on attachment 234455 [details] Patch Kling, I'm sorry for breaking debug build. I fixed the problem in last patch. Could you take a look again ?
WebKit Commit Bot
Comment 14 2014-07-06 18:22:58 PDT
Comment on attachment 234455 [details] Patch Clearing flags on attachment: 234455 Committed r170833: <http://trac.webkit.org/changeset/170833>
WebKit Commit Bot
Comment 15 2014-07-06 18:23:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.