Bug 134634

Summary: Turn on img@sizes compile flag
Product: WebKit Reporter: Yoav Weiss <yoav>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: adamschule85, akkaran046, aliahmadialexa, ap, asiapoker303, bathroomremodelrr, benjamin, bunhere, clopez, cmarcelo, commit-queue, concretecolumbia, dbates, dino, fataxef, gyuyoung.kim, johnjacobs8691, malkovichted1, ngaythamhoa110i, poker99online, rakuco, rhlmahto624, rickferri453, sergio, sherllyfoxy88, simon.fraser, syoichi, visaliapressurewashing, winnipegeavestrough, zalsosjezzamae
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Yoav Weiss
Reported 2014-07-04 06:52:06 PDT
Turn on img@sizes compile flag
Attachments
Patch (2.67 KB, patch)
2014-07-04 06:53 PDT, Yoav Weiss 		no flags
DetailsFormatted DiffDiff
Patch (13.26 KB, patch)
2014-07-06 14:21 PDT, Yoav Weiss 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yoav Weiss
Comment 1 2014-07-04 06:53:56 PDT
Created attachment 234408 [details] Patch
Dean Jackson
Comment 2 2014-07-04 12:36:54 PDT
Comment on attachment 234408 [details] Patch Alas, you need to do a bit more than this to turn it on by default. All you are doing here is toggling it to be on by default build-webkit, but not everyone uses this. You should look at the patches that change FeatureDefines.xcconfig (which covers Apple's ports) as well as other configs for the remaining ports.
Dean Jackson
Comment 3 2014-07-04 12:37:25 PDT
The r- isn't for the feature of course :)
Yoav Weiss
Comment 4 2014-07-06 14:21:19 PDT
Created attachment 234465 [details] Patch
Yoav Weiss
Comment 5 2014-07-06 14:23:07 PDT
Thanks for reviewing! :) I've added the flag and turned it on by default in a bunch of other places. I hope that covers everything.
WebKit Commit Bot
Comment 6 2014-07-06 22:02:56 PDT
Comment on attachment 234465 [details] Patch Clearing flags on attachment: 234465 Committed r170837: <http://trac.webkit.org/changeset/170837>
WebKit Commit Bot
Comment 7 2014-07-06 22:03:02 PDT
All reviewed patches have been landed. Closing bug.
Simon Fraser (smfr)
Comment 8 2014-07-08 22:54:48 PDT
This broke a test which has been causing red bots for two days now: http://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK2%20(Tests)/r170906%20(5573)/results.html
Yoav Weiss
Comment 9 2014-07-09 00:10:47 PDT
I see why this test can be flaky. I'll fix that tomorrow
Carlos Alberto Lopez Perez
Comment 10 2014-07-09 03:22:20 PDT
On platform GTK 3 of this tests are failing. Reported here: https://bugs.webkit.org/show_bug.cgi?id=134756
Note You need to log in before you can comment on or make changes to this bug.