|Summary:||Turn on img@sizes compile flag|
|Product:||WebKit||Reporter:||Yoav Weiss <yoav>|
|Component:||New Bugs||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||adamschule85, akkaran046, asiapoker303, benjamin, bunhere, clopez, cmarcelo, commit-queue, concretecolumbia, dbates, dino, fataxef, gyuyoung.kim, johnjacobs8691, malkovichted1, ngaythamhoa110i, poker99online, rakuco, sergio, sherllyfoxy88, simon.fraser, syoichi, winnipegeavestrough, zalsosjezzamae|
|Version:||528+ (Nightly build)|
Description Yoav Weiss 2014-07-04 06:52:06 PDT
Turn on img@sizes compile flag
Comment 2 Dean Jackson 2014-07-04 12:36:54 PDT
Comment on attachment 234408 [details] Patch Alas, you need to do a bit more than this to turn it on by default. All you are doing here is toggling it to be on by default build-webkit, but not everyone uses this. You should look at the patches that change FeatureDefines.xcconfig (which covers Apple's ports) as well as other configs for the remaining ports.
Comment 3 Dean Jackson 2014-07-04 12:37:25 PDT
The r- isn't for the feature of course :)
Comment 5 Yoav Weiss 2014-07-06 14:23:07 PDT
Thanks for reviewing! :) I've added the flag and turned it on by default in a bunch of other places. I hope that covers everything.
Comment 6 WebKit Commit Bot 2014-07-06 22:02:56 PDT
Comment on attachment 234465 [details] Patch Clearing flags on attachment: 234465 Committed r170837: <http://trac.webkit.org/changeset/170837>
Comment 7 WebKit Commit Bot 2014-07-06 22:03:02 PDT
All reviewed patches have been landed. Closing bug.
Comment 8 Simon Fraser (smfr) 2014-07-08 22:54:48 PDT
This broke a test which has been causing red bots for two days now: http://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK2%20(Tests)/r170906%20(5573)/results.html
Comment 9 Yoav Weiss 2014-07-09 00:10:47 PDT
I see why this test can be flaky. I'll fix that tomorrow