Summary: | Turn on img@sizes compile flag | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yoav Weiss <yoav> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | adamschule85, akkaran046, aliahmadialexa, ap, asiapoker303, bathroomremodelrr, benjamin, bunhere, clopez, cmarcelo, commit-queue, concretecolumbia, dbates, dino, fataxef, gyuyoung.kim, johnjacobs8691, malkovichted1, ngaythamhoa110i, poker99online, rakuco, rhlmahto624, rickferri453, sergio, sherllyfoxy88, simon.fraser, syoichi, visaliapressurewashing, winnipegeavestrough, zalsosjezzamae | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Yoav Weiss
2014-07-04 06:52:06 PDT
Created attachment 234408 [details]
Patch
Comment on attachment 234408 [details]
Patch
Alas, you need to do a bit more than this to turn it on by default. All you are doing here is toggling it to be on by default build-webkit, but not everyone uses this.
You should look at the patches that change FeatureDefines.xcconfig (which covers Apple's ports) as well as other configs for the remaining ports.
The r- isn't for the feature of course :) Created attachment 234465 [details]
Patch
Thanks for reviewing! :) I've added the flag and turned it on by default in a bunch of other places. I hope that covers everything. Comment on attachment 234465 [details] Patch Clearing flags on attachment: 234465 Committed r170837: <http://trac.webkit.org/changeset/170837> All reviewed patches have been landed. Closing bug. This broke a test which has been causing red bots for two days now: http://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK2%20(Tests)/r170906%20(5573)/results.html I see why this test can be flaky. I'll fix that tomorrow On platform GTK 3 of this tests are failing. Reported here: https://bugs.webkit.org/show_bug.cgi?id=134756 |