Bug 134619

Summary: [iOS WK2] Compositing layers draw outside page bounds
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Severity: Normal CC: benjamin, bunhere, cdumez, commit-queue, gyuyoung.kim, sergio, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Patch benjamin: review+

Description Simon Fraser (smfr) 2014-07-03 16:56:02 PDT
[iOS WK2] Compositing layers draw outside page bounds
Comment 1 Simon Fraser (smfr) 2014-07-03 16:59:59 PDT
Created attachment 234381 [details]
Comment 2 Simon Fraser (smfr) 2014-07-03 17:00:27 PDT
Comment 3 Benjamin Poulain 2014-07-03 17:25:09 PDT
Comment on attachment 234381 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=234381&action=review

> Source/WebKit2/UIProcess/ios/WKContentView.mm:570
> +    [_fixedClippingView setPosition:clippingBounds.location()];

UIView's setPosition is deprecated API

> Source/WebKit2/UIProcess/ios/WKContentView.mm:704
> +        FloatRect fixedPositionRect = _page->computeCustomFixedPositionRect(_page->unobscuredContentRect(), [[_webView scrollView] zoomScale]);

I think I'd prefere m_webPageProxy.displayedContentScale() here to be consistent with RemoteScrollingCoordinatorProxy::customFixedPositionRect().
I don't feel strongly about this, they should be the same values, do as you prefer.
Comment 4 Simon Fraser (smfr) 2014-07-03 17:49:06 PDT