Bug 134601
| Summary: | Rationalize the interaction between GC and the SymbolTable lock | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> |
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> |
| Status: | NEW | ||
| Severity: | Normal | CC: | barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Filip Pizlo
Currently we have everything we need to ensure that we don't do GC things while holding the SymbolTable lock, and yet we still use a GCSafeConcurrentJITLocker because of the few things that slipped through, like exception throwing.
Also, we notifyWrite() on watchpoint sets while holding the SymbolTable lock, which seems super dangerous.
We should fix this.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Filip Pizlo
The notifyWrite part will be taken care of by https://bugs.webkit.org/show_bug.cgi?id=143232.