Bug 134588

Summary:

[GTK] The list of features shown by cmake is not accurate

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bunhere, cdumez, commit-queue, gustavo, gyuyoung.kim, pnormand, rakuco, sergio

Priority:

Keywords:

Gtk

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

134589

Attachments:

Description	Flags
Patch	none
Different approach	gustavo: review+

Description Carlos Garcia Campos 2014-07-03 02:12:26 PDT

The problem is that some options might change after the feature list has been printed. Optional features might be disabled because their deps were not found, for example.

Comment 1 Carlos Garcia Campos 2014-07-03 02:15:53 PDT

Created attachment 234327 [details]
Patch

Comment 2 Carlos Garcia Campos 2014-07-03 02:38:23 PDT

Comment on attachment 234327 [details]
Patch

This doesn't really work, because it's WEBKIT_OPTION_DEFAULT_PORT_VALUE then once actually setting ENABLE_FOO

Comment 3 Carlos Garcia Campos 2014-07-03 03:02:55 PDT

Created attachment 234329 [details]
Different approach

Ok, I think this should work fine.

Comment 4 Gustavo Noronha (kov) 2014-07-03 05:53:24 PDT

Comment on attachment 234329 [details]
Different approach

Makes sense!

Comment 5 Carlos Garcia Campos 2014-07-03 06:37:17 PDT

Committed r170751: <http://trac.webkit.org/changeset/170751>