RESOLVED FIXED 134588
[GTK] The list of features shown by cmake is not accurate 
https://bugs.webkit.org/show_bug.cgi?id=134588
Summary [GTK] The list of features shown by cmake is not accurate
Carlos Garcia Campos
Reported 2014-07-03 02:12:26 PDT
The problem is that some options might change after the feature list has been printed. Optional features might be disabled because their deps were not found, for example.
Attachments
Patch (2.00 KB, patch)
2014-07-03 02:15 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Different approach (5.50 KB, patch)
2014-07-03 03:02 PDT, Carlos Garcia Campos 		gustavo: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2014-07-03 02:15:53 PDT
Created attachment 234327 [details] Patch
Carlos Garcia Campos
Comment 2 2014-07-03 02:38:23 PDT
Comment on attachment 234327 [details] Patch This doesn't really work, because it's WEBKIT_OPTION_DEFAULT_PORT_VALUE then once actually setting ENABLE_FOO
Carlos Garcia Campos
Comment 3 2014-07-03 03:02:55 PDT
Created attachment 234329 [details] Different approach Ok, I think this should work fine.
Gustavo Noronha (kov)
Comment 4 2014-07-03 05:53:24 PDT
Comment on attachment 234329 [details] Different approach Makes sense!
Carlos Garcia Campos
Comment 5 2014-07-03 06:37:17 PDT
Committed r170751: <http://trac.webkit.org/changeset/170751>
Note You need to log in before you can comment on or make changes to this bug.