Bug 134521 – iOS should use shared code to determine the system marketing version

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Mark Rowe (bdash)]

The iOS implementation of systemMarketingVersion is currently a FIXME. UserAgentIOS.mm has an implementation under the name osMarketingVersion that's virtually identical to the OS X version. We should only have a single copy of the code.

[Mark Rowe (bdash)]

Created attachment 234214 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 234214 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234214&action=review

> Source/WebCore/page/cocoa/UserAgent.mm:38
> +    return [systemMarketingVersion() stringByReplacingOccurrencesOfString:@"." withString:@"_"];

It's sad that we go from String to NSString* and back here.

[WebKit Commit Bot]

Comment on attachment 234214 [details]
Patch

Clearing flags on attachment: 234214

Committed r170730: <http://trac.webkit.org/changeset/170730>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 234214 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234214&action=review

>> Source/WebCore/page/cocoa/UserAgent.mm:38
>> +    return [systemMarketingVersion() stringByReplacingOccurrencesOfString:@"." withString:@"_"];
> 
> It's sad that we go from String to NSString* and back here.

WTF::String dose have a function to do this.

    return systemMarketingVersion.replace('.', '_');