Bug 134491

Summary: Subpixel rendering: Pixel crack in breadcrumbs at devforums.apple.com.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kondapallykalyan, sergio, simon.fraser
Priority: P2 Keywords: InRadar, Regression
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: https://devforums.apple.com/community/safari/plugins
Attachments:
Description Flags
Patch simon.fraser: review+, commit-queue: commit-queue-

zalan
Reported 2014-07-01 08:07:22 PDT
There’s a 1-pixel white vertical line going through the navigation breadcrumbs at the top of Developer Forums posts at devforums.apple.com. https://devforums.apple.com/community/safari/plugins <rdar://problem/17499160>
Attachments
Patch (10.35 KB, patch)
2014-07-01 08:36 PDT, zalan 		simon.fraser: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2014-07-01 08:36:05 PDT
Created attachment 234166 [details] Patch
Simon Fraser (smfr)
Comment 2 2014-07-01 09:57:03 PDT
Comment on attachment 234166 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234166&action=review > Source/WebCore/rendering/RenderBoxModelObject.cpp:1152 > - LayoutUnit computedXPosition = minimumValueForLength(fillLayer->xPosition(), availableWidth, true); > + LayoutUnit computedXPosition = minimumValueForLength(fillLayer->xPosition(), availableWidth, false); Classic boolean trap. No idea what true/false mean.
zalan
Comment 3 2014-07-01 10:18:47 PDT
(In reply to comment #2) > (From update of attachment 234166 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=234166&action=review > > > Source/WebCore/rendering/RenderBoxModelObject.cpp:1152 > > - LayoutUnit computedXPosition = minimumValueForLength(fillLayer->xPosition(), availableWidth, true); > > + LayoutUnit computedXPosition = minimumValueForLength(fillLayer->xPosition(), availableWidth, false); > > Classic boolean trap. No idea what true/false mean. bug 134495
WebKit Commit Bot
Comment 4 2014-07-01 10:21:05 PDT
Comment on attachment 234166 [details] Patch Rejecting attachment 234166 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 234166, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/5347005584900096
zalan
Comment 5 2014-07-01 10:25:33 PDT
Committed r170646: <http://trac.webkit.org/changeset/170646>
Note You need to log in before you can comment on or make changes to this bug.