Summary: | [GTK] Annotations for WebResource.get_data produce wrong signature in Vala binding | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | nilclass | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | berto, bunhere, cdumez, cgarcia, commit-queue, gustavo, gyuyoung.kim, mrobinson, sergio | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
nilclass
2014-06-30 17:51:16 PDT
Created attachment 234132 [details]
[GTK] fix WebKit.WebResource.get_data_finish return value annotations
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 234132 [details] [GTK] fix WebKit.WebResource.get_data_finish return value annotations Thanks for the patch. It looks good to me, but you need to fill a changelog entry, see http://www.webkit.org/coding/contributing.html Created attachment 234151 [details]
Patch for landing
Added changelog entry
Comment on attachment 234151 [details] Patch for landing Clearing flags on attachment: 234151 Committed r170633: <http://trac.webkit.org/changeset/170633> All reviewed patches have been landed. Closing bug. |