Summary: | Make TransformIterator::TransformIterator() take rvalue references | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||||
Component: | Web Template Framework | Assignee: | Daniel Bates <dbates> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, benjamin, bunhere, cdumez, cmarcelo, commit-queue, darin, gyuyoung.kim, sergio | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Daniel Bates
2014-06-30 16:30:35 PDT
Created attachment 234113 [details]
Patch
Comment on attachment 234113 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234113&action=review > Source/WTF/ChangeLog:3 > + Actually use move semantics when calling TransformIterator::TransformIterator() with rvalue references I don’t understand the point of the word “actually” here. Created attachment 234120 [details]
Patch
(In reply to comment #2) > (From update of attachment 234113 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=234113&action=review > > > Source/WTF/ChangeLog:3 > > + Actually use move semantics when calling TransformIterator::TransformIterator() with rvalue references > > I don’t understand the point of the word “actually” here. As we discussed in-person today (06/30), the purpose of this patch is to support a constructor that takes rvalue-references. It's actually sufficient to only have such a constructor. I updated the title of this bug and attached an updated patch. Committed r170615: <http://trac.webkit.org/changeset/170615> |