Bug 134454

Summary: Encode/decode CFURLRequestRefs when USE(CFNETWORK) is enabled
Product: WebKit Reporter: Pratik Solanki <psolanki>
Component: WebKit2Assignee: Pratik Solanki <psolanki>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, gyuyoung.kim, psolanki, sergio
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch kling: review+

Pratik Solanki
Reported 2014-06-30 14:02:55 PDT
We current encode/decode NSURLRequest to send over the wire. We can just use CFURLRequestRef on iOS.
Attachments
Patch (231.85 KB, patch)
2014-06-30 14:12 PDT, Pratik Solanki 		no flags
DetailsFormatted DiffDiff
Patch (231.84 KB, patch)
2014-07-01 09:54 PDT, Pratik Solanki 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pratik Solanki
Comment 1 2014-06-30 14:05:37 PDT
<rdar://problem/17510980>
Pratik Solanki
Comment 2 2014-06-30 14:12:24 PDT
Created attachment 234092 [details] Patch
Sam Weinig
Comment 3 2014-06-30 16:27:05 PDT
Comment on attachment 234092 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234092&action=review > Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:64 > + CFURLRequestSetHTTPRequestBody((CFMutableURLRequestRef)(requestToSerialize.get()), nil); > + CFURLRequestSetHTTPRequestBodyStream((CFMutableURLRequestRef)(requestToSerialize.get()), nil); These casts scare me. Can we at least use the checked_cf_cast?
Pratik Solanki
Comment 4 2014-07-01 09:49:58 PDT
Comment on attachment 234092 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234092&action=review >> Source/WebKit2/Shared/mac/WebCoreArgumentCodersMac.mm:64 >> + CFURLRequestSetHTTPRequestBodyStream((CFMutableURLRequestRef)(requestToSerialize.get()), nil); > > These casts scare me. Can we at least use the checked_cf_cast? I resorted to plain old cast since static_cast didn't work and it seems dilemma I would have to combine it with const_cast. The NSURLRequest version of the code used C casts so I just used that. I didn't know about checked_cf_cast! I tried that but that also ran into const issues. Likely would have to use another const_cast along with it. I am going to try something different instead. New patch coming up.
Pratik Solanki
Comment 5 2014-07-01 09:54:31 PDT
Created attachment 234168 [details] Patch
Andreas Kling
Comment 6 2014-07-01 13:03:38 PDT
Comment on attachment 234168 [details] Patch OK! r=me
Pratik Solanki
Comment 7 2014-07-01 17:58:23 PDT
Committed r170685: <http://trac.webkit.org/changeset/170685>
Note You need to log in before you can comment on or make changes to this bug.